This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Support text input autocomplete#39460
Merged
cbracken merged 1 commit intoflutter:mainfrom Feb 8, 2023
cbracken:textfield-touchbar
Merged
[macOS] Support text input autocomplete#39460cbracken merged 1 commit intoflutter:mainfrom cbracken:textfield-touchbar
cbracken merged 1 commit intoflutter:mainfrom
cbracken:textfield-touchbar
Conversation
cbracken
commented
Feb 7, 2023
loic-sharma
reviewed
Feb 7, 2023
shell/platform/darwin/macos/framework/Source/FlutterTextInputPlugin.mm
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Feb 7, 2023
shell/platform/darwin/macos/framework/Source/FlutterTextInputPlugin.mm
Outdated
Show resolved
Hide resolved
loic-sharma
approved these changes
Feb 7, 2023
Member
loic-sharma
left a comment
loic-sharma
left a comment
There was a problem hiding this comment.
LGTM but please also get approval from someone that's more familiar with the text input plugin
Member
|
/cc @knopp as you worked in this area recently |
shell/platform/darwin/macos/framework/Source/FlutterTextInputPlugin.mm
Outdated
Show resolved
Hide resolved
By default, autocomplete is enabled during text input on macOS. On Macs with the touchbar enabled, the current text input and any suggested autocompletions are listed in the touchbar. This adds support for disabling autocomplete when autofill is disabled, when obscureText is set in the text input configuration, and when the autofill hint type is "password" or "username". When an AutofillGroup is in use, we disable autocomplete for all fields within the group when any of the fields disables autocomplete. While OS-level autocomplete support is far more robust on iOS, this behaviour matches our enable/disable state management behaviour on that platform. Issue: flutter/flutter#119824
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, autocomplete is enabled during text input on macOS. On Macs with the touchbar enabled, the current text input and any suggested autocompletions are listed in the touchbar.
This adds support for disabling autocomplete when autofill is disabled, when obscureText is set in the text input configuration, and when the autofill hint type is "password" or "username". When an AutofillGroup is in use, we disable autocomplete for all fields within the group when any of the fields disables autocomplete.
While OS-level autocomplete support is far more robust on iOS, this behaviour matches out enable/disable state management behaviour on that platform.
Issue: flutter/flutter#119824
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.